zhdev/oblak
1
0
Fork 0
Code Issues Pull requests Activity

Remove todos

Browse source
This commit is contained in:
jmp 2021-03-19 16:51:32 -07:00 • committed by Jason
parent e98ae06594
commit ab615127b9
2 changed files with 0 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

17
cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/FabricCommandManager.java
View file

@ -192,7 +192,6 @@ public abstract class FabricCommandManager<C, S extends CommandSource> extends C
);
this.registerConstantNativeParserSupplier(NumberRange.IntRange.class, NumberRangeArgumentType.numberRange());
this.registerConstantNativeParserSupplier(NumberRange.FloatRange.class, NumberRangeArgumentType.method_30918());
// todo: can we add a compound argument -- MC `ItemStackArgument` is just type and tag, and count is separate
this.registerConstantNativeParserSupplier(ItemStackArgument.class, ItemStackArgumentType.itemStack());
/* Wrapped/Constant Brigadier types, mapped value type */
@ -201,26 +200,10 @@ public abstract class FabricCommandManager<C, S extends CommandSource> extends C
BlockPredicateArgumentType.blockPredicate()
);
this.registerConstantNativeParserSupplier(MessageArgumentType.MessageFormat.class, MessageArgumentType.message());
/*this.registerConstantNativeParserSupplier(GameProfile.class, GameProfileArgumentType.gameProfile());
this.registerConstantNativeParserSupplier(BlockPos.class, BlockPosArgumentType.blockPos());
this.registerConstantNativeParserSupplier(ColumnPos.class, ColumnPosArgumentType.columnPos());
this.registerConstantNativeParserSupplier(Vec3d.class, Vec3ArgumentType.vec3());
this.registerConstantNativeParserSupplier(Vec2f.class, Vec2ArgumentType.vec2());
this.registerConstantNativeParserSupplier(BlockState.class, BlockStateArgumentType.blockState());
this.registerConstantNativeParserSupplier(ItemPredicate.class, ItemPredicateArgumentType.itemPredicate());
this.registerConstantNativeParserSupplier(ScoreboardObjective.class, ObjectiveArgumentType.objective());
this.registerConstantNativeParserSupplier(PosArgument.class, RotationArgumentType.rotation()); // todo: different type
this.registerConstantNativeParserSupplier(ScoreboardSlotArgumentType.scoreboardSlot());
this.registerConstantNativeParserSupplier(Team.class, TeamArgumentType.team());
this.registerConstantNativeParserSupplier(/* slot *, ItemSlotArgumentType.itemSlot());
this.registerConstantNativeParserSupplier(CommandFunction.class, FunctionArgumentType.function()); */
this.getParserRegistry().registerParserSupplier(
TypeToken.get(MinecraftTime.class),
params -> FabricArgumentParsers.time()
);
/* Wrapped brigadier requiring parameters */
// score holder: single vs multiple
}
@SuppressWarnings({"unchecked", "rawtypes"})

3
cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/argument/AngleArgument.java
View file

@ -42,9 +42,6 @@ import java.util.function.BiFunction;
*/
public final class AngleArgument<C> extends CommandArgument<C, AngleArgumentType.Angle> {
// todo: This angle is relative to a certain entity
// Vanilla only supports this on the server, we should be able to make it work on the client just fine too.
AngleArgument(
final boolean required,
final @NonNull String name,