From ab615127b918225c7b980c715ec4d788414e763e Mon Sep 17 00:00:00 2001 From: jmp Date: Fri, 19 Mar 2021 16:51:32 -0700 Subject: [PATCH] Remove todos --- .../fabric/FabricCommandManager.java | 17 ----------------- .../fabric/argument/AngleArgument.java | 3 --- 2 files changed, 20 deletions(-) diff --git a/cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/FabricCommandManager.java b/cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/FabricCommandManager.java index 47491dce..93076ad6 100644 --- a/cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/FabricCommandManager.java +++ b/cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/FabricCommandManager.java @@ -192,7 +192,6 @@ public abstract class FabricCommandManager extends C ); this.registerConstantNativeParserSupplier(NumberRange.IntRange.class, NumberRangeArgumentType.numberRange()); this.registerConstantNativeParserSupplier(NumberRange.FloatRange.class, NumberRangeArgumentType.method_30918()); - // todo: can we add a compound argument -- MC `ItemStackArgument` is just type and tag, and count is separate this.registerConstantNativeParserSupplier(ItemStackArgument.class, ItemStackArgumentType.itemStack()); /* Wrapped/Constant Brigadier types, mapped value type */ @@ -201,26 +200,10 @@ public abstract class FabricCommandManager extends C BlockPredicateArgumentType.blockPredicate() ); this.registerConstantNativeParserSupplier(MessageArgumentType.MessageFormat.class, MessageArgumentType.message()); - /*this.registerConstantNativeParserSupplier(GameProfile.class, GameProfileArgumentType.gameProfile()); - this.registerConstantNativeParserSupplier(BlockPos.class, BlockPosArgumentType.blockPos()); - this.registerConstantNativeParserSupplier(ColumnPos.class, ColumnPosArgumentType.columnPos()); - this.registerConstantNativeParserSupplier(Vec3d.class, Vec3ArgumentType.vec3()); - this.registerConstantNativeParserSupplier(Vec2f.class, Vec2ArgumentType.vec2()); - this.registerConstantNativeParserSupplier(BlockState.class, BlockStateArgumentType.blockState()); - this.registerConstantNativeParserSupplier(ItemPredicate.class, ItemPredicateArgumentType.itemPredicate()); - this.registerConstantNativeParserSupplier(ScoreboardObjective.class, ObjectiveArgumentType.objective()); - this.registerConstantNativeParserSupplier(PosArgument.class, RotationArgumentType.rotation()); // todo: different type - this.registerConstantNativeParserSupplier(ScoreboardSlotArgumentType.scoreboardSlot()); - this.registerConstantNativeParserSupplier(Team.class, TeamArgumentType.team()); - this.registerConstantNativeParserSupplier(/* slot *, ItemSlotArgumentType.itemSlot()); - this.registerConstantNativeParserSupplier(CommandFunction.class, FunctionArgumentType.function()); */ this.getParserRegistry().registerParserSupplier( TypeToken.get(MinecraftTime.class), params -> FabricArgumentParsers.time() ); - - /* Wrapped brigadier requiring parameters */ - // score holder: single vs multiple } @SuppressWarnings({"unchecked", "rawtypes"}) diff --git a/cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/argument/AngleArgument.java b/cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/argument/AngleArgument.java index 82f6788b..77b06f2f 100644 --- a/cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/argument/AngleArgument.java +++ b/cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/argument/AngleArgument.java @@ -42,9 +42,6 @@ import java.util.function.BiFunction; */ public final class AngleArgument extends CommandArgument { - // todo: This angle is relative to a certain entity - // Vanilla only supports this on the server, we should be able to make it work on the client just fine too. - AngleArgument( final boolean required, final @NonNull String name,