🎨 required-> of

This commit is contained in:
Alexander Söderberg 2020-10-01 13:20:29 +02:00
parent 8d60348533
commit ee59066733
No known key found for this signature in database
GPG key ID: C0207FF7EA146678
27 changed files with 60 additions and 60 deletions

View file

@ -145,7 +145,7 @@ public class Command<C> {
@NonNull final Description description,
@NonNull final String... aliases) {
final Map<@NonNull CommandArgument<C, ?>, @NonNull Description> map = new LinkedHashMap<>();
map.put(StaticArgument.required(commandName, aliases), description);
map.put(StaticArgument.of(commandName, aliases), description);
return new Builder<>(null, commandMeta, null, map,
new CommandExecutionHandler.NullCommandExecutionHandler<>(), Permission.empty());
}
@ -164,7 +164,7 @@ public class Command<C> {
@NonNull final CommandMeta commandMeta,
@NonNull final String... aliases) {
final Map<CommandArgument<C, ?>, Description> map = new LinkedHashMap<>();
map.put(StaticArgument.required(commandName, aliases), Description.empty());
map.put(StaticArgument.of(commandName, aliases), Description.empty());
return new Builder<>(null, commandMeta, null, map,
new CommandExecutionHandler.NullCommandExecutionHandler<>(), Permission.empty());
}
@ -308,7 +308,7 @@ public class Command<C> {
*/
public @NonNull Builder<C> literal(@NonNull final String main,
@NonNull final String... aliases) {
return this.argument(StaticArgument.required(main, aliases));
return this.argument(StaticArgument.of(main, aliases));
}
/**
@ -322,7 +322,7 @@ public class Command<C> {
public @NonNull Builder<C> literal(@NonNull final String main,
@NonNull final Description description,
@NonNull final String... aliases) {
return this.argument(StaticArgument.required(main, aliases), description);
return this.argument(StaticArgument.of(main, aliases), description);
}
/**
@ -398,7 +398,7 @@ public class Command<C> {
if (this.commandManager == null) {
throw new IllegalStateException("This cannot be called from a command that has no command manager attached");
}
return this.argument(ArgumentPair.required(this.commandManager, name, names, parserPair).simple(), description);
return this.argument(ArgumentPair.of(this.commandManager, name, names, parserPair).simple(), description);
}
/**
@ -431,7 +431,7 @@ public class Command<C> {
throw new IllegalStateException("This cannot be called from a command that has no command manager attached");
}
return this.argument(
ArgumentPair.required(this.commandManager, name, names, parserPair).withMapper(outputType, mapper),
ArgumentPair.of(this.commandManager, name, names, parserPair).withMapper(outputType, mapper),
description);
}
@ -460,7 +460,7 @@ public class Command<C> {
if (this.commandManager == null) {
throw new IllegalStateException("This cannot be called from a command that has no command manager attached");
}
return this.argument(ArgumentTriplet.required(this.commandManager, name, names, parserTriplet).simple(), description);
return this.argument(ArgumentTriplet.of(this.commandManager, name, names, parserTriplet).simple(), description);
}
/**
@ -495,7 +495,7 @@ public class Command<C> {
throw new IllegalStateException("This cannot be called from a command that has no command manager attached");
}
return this.argument(
ArgumentTriplet.required(this.commandManager, name, names, parserTriplet).withMapper(outputType, mapper),
ArgumentTriplet.of(this.commandManager, name, names, parserTriplet).withMapper(outputType, mapper),
description);
}

View file

@ -56,8 +56,8 @@ public final class StaticArgument<C> extends CommandArgument<C, String> {
* @param <C> Command sender type
* @return Constructed argument
*/
public static <C> @NonNull StaticArgument<C> required(@NonNull final String name,
@NonNull final String... aliases) {
public static <C> @NonNull StaticArgument<C> of(@NonNull final String name,
@NonNull final String... aliases) {
return new StaticArgument<>(true, name, aliases);
}

View file

@ -78,11 +78,11 @@ public class ArgumentPair<C, U, V, O> extends CompoundArgument<Pair<U, V>, C, O>
* @param <V> Second parsed type
* @return Intermediary builder
*/
public static <C, U, V> @NonNull ArgumentPairIntermediaryBuilder<C, U, V> required(@NonNull final CommandManager<C> manager,
@NonNull final String name,
@NonNull final Pair<@NonNull String,
public static <C, U, V> @NonNull ArgumentPairIntermediaryBuilder<C, U, V> of(@NonNull final CommandManager<C> manager,
@NonNull final String name,
@NonNull final Pair<@NonNull String,
@NonNull String> names,
@NonNull final Pair<@NonNull Class<U>,
@NonNull final Pair<@NonNull Class<U>,
@NonNull Class<V>> types) {
final ParserRegistry<C> parserRegistry = manager.getParserRegistry();
final ArgumentParser<C, U> firstParser = parserRegistry.createParser(TypeToken.get(types.getFirst()),

View file

@ -82,10 +82,10 @@ public class ArgumentTriplet<C, U, V, W, O> extends CompoundArgument<Triplet<U,
* @return Intermediary builder
*/
public static <C, U, V, W> @NonNull ArgumentTripletIntermediaryBuilder<@NonNull C, @NonNull U, @NonNull V, @NonNull W>
required(@NonNull final CommandManager<C> manager,
@NonNull final String name,
@NonNull final Triplet<@NonNull String, @NonNull String, @NonNull String> names,
@NonNull final Triplet<@NonNull Class<U>, @NonNull Class<V>, @NonNull Class<W>> types) {
of(@NonNull final CommandManager<C> manager,
@NonNull final String name,
@NonNull final Triplet<@NonNull String, @NonNull String, @NonNull String> names,
@NonNull final Triplet<@NonNull Class<U>, @NonNull Class<V>, @NonNull Class<W>> types) {
final ParserRegistry<C> parserRegistry = manager.getParserRegistry();
final ArgumentParser<C, U> firstParser = parserRegistry.createParser(TypeToken.get(types.getFirst()),
ParserParameters.empty()).orElseThrow(() ->

View file

@ -67,7 +67,7 @@ public final class BooleanArgument<C> extends CommandArgument<C, Boolean> {
* @param <C> Command sender type
* @return Created argument
*/
public static <C> @NonNull CommandArgument<C, Boolean> required(@NonNull final String name) {
public static <C> @NonNull CommandArgument<C, Boolean> of(@NonNull final String name) {
return BooleanArgument.<C>newBuilder(name).asRequired().build();
}

View file

@ -71,7 +71,7 @@ public final class ByteArgument<C> extends CommandArgument<C, Byte> {
* @param <C> Command sender type
* @return Created argument
*/
public static <C> @NonNull CommandArgument<C, Byte> required(@NonNull final String name) {
public static <C> @NonNull CommandArgument<C, Byte> of(@NonNull final String name) {
return ByteArgument.<C>newBuilder(name).asRequired().build();
}

View file

@ -63,7 +63,7 @@ public final class CharArgument<C> extends CommandArgument<C, Character> {
* @param <C> Command sender type
* @return Created argument
*/
public static <C> @NonNull CommandArgument<C, Character> required(@NonNull final String name) {
public static <C> @NonNull CommandArgument<C, Character> of(@NonNull final String name) {
return CharArgument.<C>newBuilder(name).asRequired().build();
}

View file

@ -71,7 +71,7 @@ public final class DoubleArgument<C> extends CommandArgument<C, Double> {
* @param <C> Command sender type
* @return Created argument
*/
public static <C> @NonNull CommandArgument<C, Double> required(@NonNull final String name) {
public static <C> @NonNull CommandArgument<C, Double> of(@NonNull final String name) {
return DoubleArgument.<C>newBuilder(name).asRequired().build();
}

View file

@ -78,7 +78,7 @@ public class EnumArgument<C, E extends Enum<E>> extends CommandArgument<C, E> {
* @param <E> Enum type
* @return Created argument
*/
public static <C, E extends Enum<E>> @NonNull CommandArgument<C, E> required(
public static <C, E extends Enum<E>> @NonNull CommandArgument<C, E> of(
@NonNull final Class<E> enumClass,
@NonNull final String name) {
return EnumArgument.<C, E>newBuilder(enumClass, name).asRequired().build();

View file

@ -71,7 +71,7 @@ public final class FloatArgument<C> extends CommandArgument<C, Float> {
* @param <C> Command sender type
* @return Created argument
*/
public static <C> @NonNull CommandArgument<C, Float> required(@NonNull final String name) {
public static <C> @NonNull CommandArgument<C, Float> of(@NonNull final String name) {
return FloatArgument.<C>newBuilder(name).asRequired().build();
}

View file

@ -78,7 +78,7 @@ public final class IntegerArgument<C> extends CommandArgument<C, Integer> {
* @param <C> Command sender type
* @return Created argument
*/
public static <C> @NonNull CommandArgument<C, Integer> required(@NonNull final String name) {
public static <C> @NonNull CommandArgument<C, Integer> of(@NonNull final String name) {
return IntegerArgument.<C>newBuilder(name).asRequired().build();
}

View file

@ -71,7 +71,7 @@ public final class LongArgument<C> extends CommandArgument<C, Long> {
* @param <C> Command sender type
* @return Created argument
*/
public static <C> @NonNull CommandArgument<C, Long> required(@NonNull final String name) {
public static <C> @NonNull CommandArgument<C, Long> of(@NonNull final String name) {
return LongArgument.<C>newBuilder(name).asRequired().build();
}

View file

@ -71,7 +71,7 @@ public final class ShortArgument<C> extends CommandArgument<C, Short> {
* @param <C> Command sender type
* @return Created argument
*/
public static <C> @NonNull CommandArgument<C, Short> required(@NonNull final String name) {
public static <C> @NonNull CommandArgument<C, Short> of(@NonNull final String name) {
return ShortArgument.<C>newBuilder(name).asRequired().build();
}

View file

@ -69,7 +69,7 @@ public final class StringArgument<C> extends CommandArgument<C, String> {
* @param <C> Command sender type
* @return Created argument
*/
public static <C> @NonNull CommandArgument<C, String> required(@NonNull final String name) {
public static <C> @NonNull CommandArgument<C, String> of(@NonNull final String name) {
return StringArgument.<C>newBuilder(name).single().asRequired().build();
}
@ -81,8 +81,8 @@ public final class StringArgument<C> extends CommandArgument<C, String> {
* @param <C> Command sender type
* @return Created argument
*/
public static <C> @NonNull CommandArgument<C, String> required(@NonNull final String name,
@NonNull final StringMode stringMode) {
public static <C> @NonNull CommandArgument<C, String> of(@NonNull final String name,
@NonNull final StringMode stringMode) {
return StringArgument.<C>newBuilder(name).withMode(stringMode).asRequired().build();
}

View file

@ -64,7 +64,7 @@ public final class UUIDArgument<C> extends CommandArgument<C, UUID> {
* @param <C> Command sender type
* @return Created component
*/
public static <C> @NonNull CommandArgument<C, UUID> required(@NonNull final String name) {
public static <C> @NonNull CommandArgument<C, UUID> of(@NonNull final String name) {
return UUIDArgument.<C>newBuilder(name).asRequired().build();
}

View file

@ -47,7 +47,7 @@ class CommandHelpHandlerTest {
manager.command(manager.commandBuilder("test", meta1).literal("this").literal("thing").build());
final SimpleCommandMeta meta2 = SimpleCommandMeta.builder().with("description", "Command with variables").build();
manager.command(manager.commandBuilder("test", meta2).literal("int").
argument(IntegerArgument.required("int"), Description.of("A number")).build());
argument(IntegerArgument.of("int"), Description.of("A number")).build());
manager.command(manager.commandBuilder("vec")
.meta("description", "Takes in a vector")

View file

@ -40,7 +40,7 @@ public class CommandPreProcessorTest {
static void newTree() {
manager = new TestCommandManager();
manager.command(manager.commandBuilder("test", SimpleCommandMeta.empty())
.argument(EnumArgument.required(SampleEnum.class, "enum"))
.argument(EnumArgument.of(SampleEnum.class, "enum"))
.handler(
commandContext -> System.out.printf("enum = %s | integer = %d\n",
commandContext.<SampleEnum>get(

View file

@ -49,7 +49,7 @@ public class CommandSuggestionsTest {
.argument(StringArgument.<TestCommandSender>newBuilder("str")
.withSuggestionsProvider((c, s) -> Arrays.asList("one", "two"))
.build())
.argument(EnumArgument.required(TestEnum.class, "enum"))
.argument(EnumArgument.of(TestEnum.class, "enum"))
.build());
manager.command(manager.commandBuilder("test")
.literal("comb")
@ -68,7 +68,7 @@ public class CommandSuggestionsTest {
manager.command(manager.commandBuilder("com")
.argumentPair("com", Pair.of("x", "y"), Pair.of(Integer.class, TestEnum.class),
Description.empty())
.argument(IntegerArgument.required("int"))
.argument(IntegerArgument.of("int"))
.build());
manager.command(manager.commandBuilder("com2")

View file

@ -39,7 +39,7 @@ class CommandTest {
void ensureOrdering() {
Assertions.assertThrows(IllegalArgumentException.class, () ->
Command.newBuilder("test", SimpleCommandMeta.empty()).argument(StaticArgument.optional("something"))
.argument(StaticArgument.required("somethingelse")).build());
.argument(StaticArgument.of("somethingelse")).build());
}
}

View file

@ -65,8 +65,8 @@ class CommandTreeTest {
/* Build command to test command proxying */
final Command<TestCommandSender> toProxy = manager.commandBuilder("test")
.literal("unproxied")
.argument(StringArgument.required("string"))
.argument(IntegerArgument.required("int"))
.argument(StringArgument.of("string"))
.argument(IntegerArgument.of("int"))
.literal("anotherliteral")
.handler(c -> {})
.build();
@ -86,7 +86,7 @@ class CommandTreeTest {
/* Build command for testing compound types */
manager.command(manager.commandBuilder("pos")
.argument(ArgumentPair.required(manager, "pos", Pair.of("x", "y"),
.argument(ArgumentPair.of(manager, "pos", Pair.of("x", "y"),
Pair.of(Integer.class, Integer.class))
.simple())
.handler(c -> {
@ -95,7 +95,7 @@ class CommandTreeTest {
})
.build());
manager.command(manager.commandBuilder("vec")
.argument(ArgumentPair.required(manager, "vec", Pair.of("x", "y"),
.argument(ArgumentPair.of(manager, "vec", Pair.of("x", "y"),
Pair.of(Double.class, Double.class))
.withMapper(Vector2.class,
pair -> new Vector2(pair.getFirst(), pair.getSecond()))

View file

@ -39,8 +39,8 @@ class StringArgumentTest {
static void setup() {
manager = new TestCommandManager();
manager.command(manager.commandBuilder("quoted")
.argument(StringArgument.required("message1", StringArgument.StringMode.QUOTED))
.argument(StringArgument.required("message2"))
.argument(StringArgument.of("message1", StringArgument.StringMode.QUOTED))
.argument(StringArgument.of("message2"))
.handler(c -> {
final String message1 = c.getRequired("message1");
final String message2 = c.getRequired("message2");
@ -49,14 +49,14 @@ class StringArgumentTest {
})
.build());
manager.command(manager.commandBuilder("single")
.argument(StringArgument.required("message"))
.argument(StringArgument.of("message"))
.handler(c -> {
final String message = c.getRequired("message");
storage[0] = message;
})
.build());
manager.command(manager.commandBuilder("greedy")
.argument(StringArgument.required("message", StringArgument.StringMode.GREEDY))
.argument(StringArgument.of("message", StringArgument.StringMode.GREEDY))
.handler(c -> {
final String message = c.getRequired("message");
storage[0] = message;