zhdev/oblak
1
0
Fork 0
Code Issues Pull requests Activity

🚚 Begin migrating from javax annotations to checker-qual

Browse source
This commit is contained in:
Alexander Söderberg 2020-09-28 16:40:06 +02:00 • committed by Alexander Söderberg
parent e914d04450
commit 9f0c846050
43 changed files with 273 additions and 549 deletions
Download patch file Download diff file Expand all files Collapse all files

4
cloud-services/src/test/java/cloud/commandframework/services/mock/AnnotatedMethodTest.java
View file

@ -25,12 +25,10 @@ package cloud.commandframework.services.mock;
import cloud.commandframework.services.annotations.ServiceImplementation;
import javax.annotation.Nonnull;
public class AnnotatedMethodTest {
@ServiceImplementation(MockService.class)
public MockService.MockResult handle(@Nonnull final MockService.MockContext context) {
public MockService.MockResult handle(final MockService.MockContext context) {
return new MockService.MockResult(context.getString().length());
}

5
cloud-services/src/test/java/cloud/commandframework/services/mock/CompletingPartialResultService.java
View file

@ -23,17 +23,14 @@
//
package cloud.commandframework.services.mock;
import javax.annotation.Nonnull;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
public class CompletingPartialResultService implements MockPartialResultService {
@Nonnull
@Override
public Map<MockChunkedRequest.Animal, MockChunkedRequest.Sound> handleRequests(
@Nonnull List<MockChunkedRequest.Animal> requests) {
public Map<MockChunkedRequest.Animal, MockChunkedRequest.Sound> handleRequests(List<MockChunkedRequest.Animal> requests) {
final Map<MockChunkedRequest.Animal, MockChunkedRequest.Sound> map = new HashMap<>();
for (final MockChunkedRequest.Animal animal : requests) {
if (animal.getName().equals("cow")) {

6
cloud-services/src/test/java/cloud/commandframework/services/mock/DefaultMockService.java
View file

@ -23,14 +23,10 @@
//
package cloud.commandframework.services.mock;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
public class DefaultMockService implements MockService {
@Nullable
@Override
public MockResult handle(@Nonnull final MockContext mockContext)
public MockResult handle(final MockContext mockContext)
throws Exception {
if (mockContext.getString().equals("pls throw exception")) {
throw new TotallyIntentionalException();

5
cloud-services/src/test/java/cloud/commandframework/services/mock/DefaultPartialRequestService.java
View file

@ -23,17 +23,14 @@
//
package cloud.commandframework.services.mock;
import javax.annotation.Nonnull;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
public class DefaultPartialRequestService implements MockPartialResultService {
@Nonnull
@Override
public Map<MockChunkedRequest.Animal, MockChunkedRequest.Sound> handleRequests(
@Nonnull final List<MockChunkedRequest.Animal> requests) {
public Map<MockChunkedRequest.Animal, MockChunkedRequest.Sound> handleRequests(final List<MockChunkedRequest.Animal> requests) {
final Map<MockChunkedRequest.Animal, MockChunkedRequest.Sound> map =
new HashMap<>(requests.size());
for (final MockChunkedRequest.Animal animal : requests) {

5
cloud-services/src/test/java/cloud/commandframework/services/mock/DefaultSideEffectService.java
View file

@ -25,13 +25,10 @@ package cloud.commandframework.services.mock;
import cloud.commandframework.services.State;
import javax.annotation.Nonnull;
public class DefaultSideEffectService implements MockSideEffectService {
@Nonnull
@Override
public State handle(@Nonnull final MockPlayer mockPlayer) {
public State handle(final MockPlayer mockPlayer) {
mockPlayer.setHealth(0);
return State.ACCEPTED;
}

4
cloud-services/src/test/java/cloud/commandframework/services/mock/InterruptingMockConsumer.java
View file

@ -25,12 +25,10 @@ package cloud.commandframework.services.mock;
import cloud.commandframework.services.types.ConsumerService;
import javax.annotation.Nonnull;
public class InterruptingMockConsumer implements MockConsumerService {
@Override
public void accept(@Nonnull final MockService.MockContext mockContext) {
public void accept(final MockService.MockContext mockContext) {
ConsumerService.interrupt();
}

9
cloud-services/src/test/java/cloud/commandframework/services/mock/MockChunkedRequest.java
View file

@ -25,13 +25,12 @@ package cloud.commandframework.services.mock;
import cloud.commandframework.services.ChunkedRequestContext;
import javax.annotation.Nonnull;
import java.util.Collection;
public class MockChunkedRequest
extends ChunkedRequestContext<MockChunkedRequest.Animal, MockChunkedRequest.Sound> {
public MockChunkedRequest(@Nonnull final Collection<Animal> requests) {
public MockChunkedRequest(final Collection<Animal> requests) {
super(requests);
}
@ -39,11 +38,10 @@ public class MockChunkedRequest
private final String name;
public Animal(@Nonnull final String name) {
public Animal(final String name) {
this.name = name;
}
@Nonnull
public String getName() {
return this.name;
}
@ -54,11 +52,10 @@ public class MockChunkedRequest
private final String sound;
public Sound(@Nonnull final String sound) {
public Sound(final String sound) {
this.sound = sound;
}
@Nonnull
public String getSound() {
return this.sound;
}

6
cloud-services/src/test/java/cloud/commandframework/services/mock/MockOrderedFirst.java
View file

@ -26,15 +26,11 @@ package cloud.commandframework.services.mock;
import cloud.commandframework.services.ExecutionOrder;
import cloud.commandframework.services.annotations.Order;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
@Order(ExecutionOrder.FIRST)
public class MockOrderedFirst implements MockService {
@Nullable
@Override
public MockResult handle(@Nonnull final MockContext mockContext) {
public MockResult handle(final MockContext mockContext) {
return new MockResult(1);
}

6
cloud-services/src/test/java/cloud/commandframework/services/mock/MockOrderedLast.java
View file

@ -26,15 +26,11 @@ package cloud.commandframework.services.mock;
import cloud.commandframework.services.ExecutionOrder;
import cloud.commandframework.services.annotations.Order;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
@Order(ExecutionOrder.LAST)
public class MockOrderedLast implements MockService {
@Nullable
@Override
public MockResult handle(@Nonnull final MockContext mockContext) {
public MockResult handle(final MockContext mockContext) {
return new MockResult(2);
}

5
cloud-services/src/test/java/cloud/commandframework/services/mock/MockResultConsumer.java
View file

@ -26,13 +26,10 @@ package cloud.commandframework.services.mock;
import cloud.commandframework.services.State;
import cloud.commandframework.services.types.SideEffectService;
import javax.annotation.Nonnull;
public class MockResultConsumer implements SideEffectService<MockService.MockResult> {
@Nonnull
@Override
public State handle(@Nonnull final MockService.MockResult mockResultConsumer) {
public State handle(final MockService.MockResult mockResultConsumer) {
return State.ACCEPTED;
}

8
cloud-services/src/test/java/cloud/commandframework/services/mock/MockService.java
View file

@ -25,8 +25,6 @@ package cloud.commandframework.services.mock;
import cloud.commandframework.services.types.Service;
import javax.annotation.Nonnull;
public interface MockService extends Service<MockService.MockContext, MockService.MockResult> {
class MockContext {
@ -34,21 +32,19 @@ public interface MockService extends Service<MockService.MockContext, MockServic
private final String string;
private String state = "";
public MockContext(@Nonnull final String string) {
public MockContext( final String string) {
this.string = string;
}
@Nonnull
public String getString() {
return this.string;
}
@Nonnull
public String getState() {
return this.state;
}
public void setState(@Nonnull final String state) {
public void setState( final String state) {
this.state = state;
}

5
cloud-services/src/test/java/cloud/commandframework/services/mock/SecondaryMockService.java
View file

@ -23,15 +23,12 @@
//
package cloud.commandframework.services.mock;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
import java.util.function.Predicate;
public class SecondaryMockService implements MockService, Predicate<MockService.MockContext> {
@Nullable
@Override
public MockResult handle(@Nonnull final MockContext mockContext) {
public MockResult handle(final MockContext mockContext) {
return new MockResult(999);
}

5
cloud-services/src/test/java/cloud/commandframework/services/mock/SecondaryMockSideEffectService.java
View file

@ -25,13 +25,10 @@ package cloud.commandframework.services.mock;
import cloud.commandframework.services.State;
import javax.annotation.Nonnull;
public class SecondaryMockSideEffectService implements MockSideEffectService {
@Nonnull
@Override
public State handle(@Nonnull final MockPlayer mockPlayer) {
public State handle(final MockPlayer mockPlayer) {
return null;
}

4
cloud-services/src/test/java/cloud/commandframework/services/mock/StateSettingConsumerService.java
View file

@ -23,12 +23,10 @@
//
package cloud.commandframework.services.mock;
import javax.annotation.Nonnull;
public class StateSettingConsumerService implements MockConsumerService {
@Override
public void accept(@Nonnull final MockService.MockContext mockContext) {
public void accept(final MockService.MockContext mockContext) {
mockContext.setState("");
}