zhdev/oblak
1
0
Fork 0
Code Issues Pull requests Activity

chore(core): deprecate prefixed accessors/mutators in CommandManager (#377)

Browse source 
chore(core): deprecate prefixed accessors/mutators in CommandManager.java

All prefixed (actual) getters/setters in CommandManager have been deprecated, and non-prefixed alternatives have been introduced. I've also put some effort into improving the JavaDocs of these methods.
This commit is contained in:
Alexander Söderberg 2022-06-13 10:57:12 +02:00 • committed by Jason
parent 687cd4c536
commit 296539d56c
48 changed files with 400 additions and 157 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cloud-discord/cloud-javacord/src/main/java/cloud/commandframework/javacord/JavacordCommandManager.java
View file

@ -71,7 +71,7 @@ public class JavacordCommandManager<C> extends CommandManager<C> {
@NonNull String, @NonNull Boolean> commandPermissionMapper
) {
super(commandExecutionCoordinator, new JavacordRegistrationHandler<>());
((JavacordRegistrationHandler<C>) this.getCommandRegistrationHandler()).initialize(this);
((JavacordRegistrationHandler<C>) this.commandRegistrationHandler()).initialize(this);
this.discordApi = discordApi;
this.commandSenderMapper = commandSenderMapper;
this.backwardsCommandSenderMapper = backwardsCommandSenderMapper;

6
cloud-discord/cloud-jda/src/main/java/cloud/commandframework/jda/JDACommandManager.java
View file

@ -105,16 +105,16 @@ public class JDACommandManager<C> extends CommandManager<C> {
this.registerCommandPreProcessor(new JDACommandPreprocessor<>(this));
/* Register JDA Parsers */
this.getParserRegistry().registerParserSupplier(TypeToken.get(User.class), parserParameters ->
this.parserRegistry().registerParserSupplier(TypeToken.get(User.class), parserParameters ->
new UserArgument.UserParser<>(
new HashSet<>(Arrays.asList(UserArgument.ParserMode.values())),
UserArgument.Isolation.GLOBAL
));
this.getParserRegistry().registerParserSupplier(TypeToken.get(MessageChannel.class), parserParameters ->
this.parserRegistry().registerParserSupplier(TypeToken.get(MessageChannel.class), parserParameters ->
new ChannelArgument.MessageParser<>(
new HashSet<>(Arrays.asList(ChannelArgument.ParserMode.values()))
));
this.getParserRegistry().registerParserSupplier(TypeToken.get(Role.class), parserParameters ->
this.parserRegistry().registerParserSupplier(TypeToken.get(Role.class), parserParameters ->
new RoleArgument.RoleParser<>(
new HashSet<>(Arrays.asList(RoleArgument.ParserMode.values()))
));