From e8200281431c6a4d5d1c64c4ec61ec23472329f0 Mon Sep 17 00:00:00 2001 From: Roman Zhuravlev Date: Sat, 20 Sep 2025 01:33:23 +0500 Subject: [PATCH] Use Collection instead of List --- .../common/managers/AbstractPluginManager.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Common/src/main/java/net/frankheijden/serverutils/common/managers/AbstractPluginManager.java b/Common/src/main/java/net/frankheijden/serverutils/common/managers/AbstractPluginManager.java index bbdd06a..8bb374a 100644 --- a/Common/src/main/java/net/frankheijden/serverutils/common/managers/AbstractPluginManager.java +++ b/Common/src/main/java/net/frankheijden/serverutils/common/managers/AbstractPluginManager.java @@ -39,7 +39,7 @@ public abstract class AbstractPluginManager loadPlugins(List files) { - List descriptions = new ArrayList<>(files.size()); + Set descriptions = new HashSet<>(files.size()); for (File file : files) { D description; @@ -117,7 +117,7 @@ public abstract class AbstractPluginManager checkPluginStates(List

plugins, boolean enabled) { + protected Optional

checkPluginStates(Collection

plugins, boolean enabled) { for (P plugin : plugins) { if (isPluginEnabled(plugin) != enabled) { return Optional.of(plugin); @@ -142,7 +142,7 @@ public abstract class AbstractPluginManager disablePlugins(List

plugins) { + public PluginResults

disablePlugins(Collection

plugins) { Optional

pluginOptional = checkPluginStates(plugins, true); if (pluginOptional.isPresent()) { return new PluginResults

().addResult(getPluginId(pluginOptional.get()), Result.ALREADY_DISABLED); @@ -235,7 +235,7 @@ public abstract class AbstractPluginManager unloadPlugins(List

plugins) { + public CloseablePluginResults

unloadPlugins(Collection

plugins) { List

orderedPlugins; try { orderedPlugins = determineLoadOrder(plugins); @@ -259,7 +259,7 @@ public abstract class AbstractPluginManager determineLoadOrder(List

plugins) throws IllegalStateException { + public List

determineLoadOrder(Collection

plugins) throws IllegalStateException { Map descriptionMap = new HashMap<>(plugins.size()); for (P plugin : plugins) { descriptionMap.put(getLoadedPluginDescription(plugin), plugin); @@ -276,7 +276,7 @@ public abstract class AbstractPluginManager determineLoadOrder(Collection descriptions) throws IllegalStateException { + public List determineLoadOrder(Set descriptions) throws IllegalStateException { Map pluginIdToDescriptionMap = new HashMap<>(); for (D description : descriptions) { pluginIdToDescriptionMap.put(description.getId(), description);